نسخههای متأثر
- نسخههای متأثر
- < 1.0.0-beta.16
- نسخهٔ اصلاحشده
- 1.0.0-beta.16
شرح آسیبپذیری
Summary
Event log data is not properly sanitized leading to stored Cross-Site Scripting (XSS) vulnerability.
Details
file: https://github.com/saltcorn/saltcorn/blob/v1.0.0-beta.13/packages/server/routes/eventlog.js#L445
router.get(
"/:id",
isAdmin,
error_catcher(async (req, res) => {
const { id } = req.params;
const ev = await EventLog.findOneWithUser(id);
send_events_page({
[...]
contents: {
type: "card",
contents:
[...]
) +
div(
{ class: "eventpayload" },
ev.payload ? pre(JSON.stringify(ev.payload, null, 2)) : "" //<---
),
},
});
})
PoC
The following PoC demonstrates how a non-admin user with permission to read/write on a table can inject malicious javascript code that will be executed in the event log admin panel if event logs are enabled.
To demonstrate this issue, we need to prepare some components. The following steps should be executed with an admin user.
create a table with one column of type string set read/write permission to staff users (just as an example)
visit
http://localhost:3000/table/newcreate a table with
Table namemy_table_xssand clickCreateclick
Add fieldto add a field withLabelcalledpayloadof typeStringand clickNext >>leave default values for
Attributesand clickNext >>- it should redirect tohttp://localhost:3000/table/<table-number>under
Edit table properties, setMinimum role to readandMinimum role to writetostaff
create an edit view so that staff users can insert more data
visit
http://localhost:3000/vieweditanc clickCreate Viewset the following values:
View name:my_xss_viewView pattern:EditTable:my_table_xssMinimum role:staff
click
Configure >>on page
http://localhost:3000/viewedit/config/my_xss_viewclickNext >>and thenFinish >>you should see a message
View my_xss_view saved
edit the site structure to add the View just created so that
staffusers can access it
visit
http://localhost:3000/menuset the following values:
Type:ViewView:my_xss_view [Edit]Text label:viewMinimum role:staff
click
Add
create an event that will log when data is inserted in the
my_table_xsstable create at step 1
visit
http://localhost:3000/eventlog/settingsunder
Which events should be logged?select:[X] Insert[X] Insert my_table_xss
Login with a user with staff role (you can do the same steps also with an admin user)
visit
http://localhost:3000/view/my_xss_viewin the
payloadfield insert"<svg/onload=alert(`xss`)>and clickSave
With an admin user inspect the log entry generated by the above action:
visit
http://localhost:3000/eventlogclick on the event log generated (
http://localhost:3000/eventlog/<event-number>)an alert will appear
Impact
Stored Cross-Site Scripting (XSS)
Recommended Mitigation
Sanitize the user input before building HTML elements
پیوندها
- https://github.com/advisories/GHSA-pf56-h9qf-rxq4
- https://github.com/saltcorn/saltcorn
- https://github.com/saltcorn/saltcorn/blob/v1.0.0-beta.13/packages/server/routes/eventlog.js#L445
- https://github.com/saltcorn/saltcorn/commit/3c551261d0e230635774798009951fa83a07cc3a
- https://github.com/saltcorn/saltcorn/security/advisories/GHSA-pf56-h9qf-rxq4
گزارشدهندگان
- dellalibera

