نسخههای متأثر
- نسخههای متأثر
- < 10.0.19
- نسخهٔ اصلاحشده
- 10.0.19
بهرهبرداری
شرح آسیبپذیری
Summary
OneUptime's GitHub App callback trusts attacker-controlled state and installation_id values and updates Project.gitHubAppInstallationId with isRoot: true without validating that the caller is authorized for the target project. This allows an attacker to overwrite another project's GitHub App installation binding.
Related GitHub endpoints also lack effective authorization, so a valid installation ID can be used to enumerate repositories and create CodeRepository records in an arbitrary project.
Details
The callback decodes unsigned base64 JSON from state and uses the embedded projectId directly:
It then writes the supplied installation_id into the target project with root privileges:
await ProjectService.updateOneById({
id: new ObjectID(projectId),
data: { gitHubAppInstallationId: installationId },
props: { isRoot: true },
});
The userId in state is only checked for presence, not authenticity:
The install flow also generates state as plain base64 JSON, not a signed or session-bound token:
The follow-on endpoints are also vulnerable:
Repository listing: https://github.com/OneUptime/oneuptime/blob/master/Common/Server/API/GitHubAPI.ts#L179-L258
Repository connect: https://github.com/OneUptime/oneuptime/blob/master/Common/Server/API/GitHubAPI.ts#L260-L356
Middleware allows requests with no token to continue as
Public: https://github.com/OneUptime/oneuptime/blob/master/Common/Server/Middleware/UserAuthorization.ts#L205-L211Installation tokens are minted from any valid installation ID: https://github.com/OneUptime/oneuptime/blob/master/Common/Server/Utils/CodeRepository/GitHub/GitHub.ts#L347-L425
PoC
Minimal proof of unauthorized project tampering:
STATE=$(printf '%s' '{"projectId":"<victim-project-uuid>","userId":"x"}' | base64 | tr -d '\n')
curl -isk "https://<host>/api/github/auth/callback?installation_id=999999999&state=${STATE}"
Expected result:
Server returns a
302redirect to/dashboard/<victim-project-uuid>/code-repository?installation_id=999999999The target project's
gitHubAppInstallationIdis overwritten
Impact
Unauthorized modification of
Project.gitHubAppInstallationIdTemporary GitHub integration breakage if a bogus installation ID is set
Cross-project binding of attacker-controlled GitHub App installations
Repository metadata disclosure for a supplied valid installation ID
Unauthorized creation of
CodeRepositoryrecords in arbitrary projects
پیوندها
- https://github.com/OneUptime/oneuptime
- https://github.com/OneUptime/oneuptime/blob/master/Common/Server/API/GitHubAPI.ts#L127-L165
- https://github.com/OneUptime/oneuptime/blob/master/Common/Server/API/GitHubAPI.ts#L179-L258
- https://github.com/OneUptime/oneuptime/blob/master/Common/Server/API/GitHubAPI.ts#L260-L356
- https://github.com/OneUptime/oneuptime/blob/master/Common/Server/API/GitHubAPI.ts#L34-L112
- https://github.com/OneUptime/oneuptime/blob/master/Common/Server/API/GitHubAPI.ts#L73-L79
- https://github.com/OneUptime/oneuptime/blob/master/Common/Server/Middleware/UserAuthorization.ts#L205-L211
- https://github.com/OneUptime/oneuptime/blob/master/Common/Server/Utils/CodeRepository/GitHub/GitHub.ts#L347-L425
- https://github.com/OneUptime/oneuptime/security/advisories/GHSA-656w-6f6c-m9r6
- https://github.com/advisories/GHSA-656w-6f6c-m9r6
- https://nvd.nist.gov/vuln/detail/CVE-2026-30920
گزارشدهندگان
- maru1009

